I spose it depends what style of music you're into... for many kinds of music, the best thing you do is get yourself in a band and go out and play... this will develop your ear and give you the best idea of what works & what doesn't work
and for many kinds of music, a good ear beats a good sense of music theory or fast fingers any day
nuthing wrong with learning theory but i reckon it's ultimately best learned as an explanation of what your ear already is used to hearing...