I think the Floyd situation is kinda complex.
Gilmour was hired as a sideman.
Then he later rebelled and kicked the main songwriter in the band out. Over a decade long Cold War.
That, by modern standards, is super sketchy. He at any time could have pulled his head out of his ass, and just gotten along with the band leader. Which is expected when you're brought into a successful working band, as a nobody.
But for some reason people generally don't frame it as "former side man, who then was allowed to have an oversized creative presence in the band, rebelled." Probably because Gilmour ended up with the band name. So all of the label's advertising money went to supporting his narrative.
From the side of Waters, I can see that being very hard to swallow. "We hired you as a replacement and you decided to take the whole thing over. Then spent decades bashing me via the media." Hard to move past that.
That's an interesting take on the situation. Not exactly what I have gotten out of the biography's I've read.
In his eyes it was "they didn't show up prepared with song ideas and someone had to take charge."
The impression I got, particularly from Nick Mason's auto-biography, was that after "The Wall", Waters came in with "The Final Cut" and basically said that was the album they were going to record and the others could pretty much like it or leave.
Yet despite having played with Barrett, Gilmour happily said "yes" when he was asked to replace him.
That frankly doesn't paint him in a positive light, in my opinion.
Gilmour was asked to join the band
before Barrett was ousted. Nick Mason said that they were getting sick of Sid's erratic behaviour and they basically "deliberately forgot" to pick him up for a gig. He goes on to say that if they were older they'd have probably dealt with it in a better way but at the time they were young and just didn't want to deal with Sid's issues. Gilmour wasn't brought in to actually replace Sid, he was brought in originally to add another guitar and, to a certain extent, cover up for Sid's increasingly uncertain playing.
Do you feel the same way about Roger basically deciding he was the band leader after Sid left?
It's probably hard to know for sure, but if Gilmour was never in Pink Floyd, I think they'd have been a footnote in history at best.
It's impossible to know, but Gilmour's playing and note choice are a BIG part of why the post-Sid Pink Floyd were so good...... along with Water's song writing.
I think reading a few bios will paint a clear picture. I've read 3-4 over the years and have confidence in my view of how dysfunctional Syd was overall.
I've also read just about anything Floyd that I can get my hands on with Nick Mason's auto-biography probably being one of the best due to the fact that he lived the whole experience from within.
I think my favorourite quote from Mason was about the ousting of Roger. By the time they did "The Final Cut" Roger was being more demanding and controlling to the point that others were really getting sick of him.
Nick says "Roger told the rest of the band
that nobody in Pink Floyd is irreplaceable and he was right"