There seems to be a bit of conflict of opinion here. It probably won't settle the argument, but here's my take on shielding and grounding.
1. I always shield my electronics cavities. It makes a noticeable difference.
2. I always bring all signal grounds to a central point. This is the "star" grounding method, and it avoids ground loops. A ground loop is where there are two or more separate points used as ground. Although they are electrically connected to each other, there is finite resistance in the connection, meaning that the different grounds can have different potentials. Sometimes this is not a problem, but sometimes it can cause noise.
3. My star grounding point includes the shield. That is to say the shield only connects to signal ground at one point. This also avoids ground loops, while ensuring that all pot and switch casings are grounded.
1. I always shield my electronics cavities. It makes a noticeable difference.
2. I always bring all signal grounds to a central point. This is the "star" grounding method, and it avoids ground loops. A ground loop is where there are two or more separate points used as ground. Although they are electrically connected to each other, there is finite resistance in the connection, meaning that the different grounds can have different potentials. Sometimes this is not a problem, but sometimes it can cause noise.
3. My star grounding point includes the shield. That is to say the shield only connects to signal ground at one point. This also avoids ground loops, while ensuring that all pot and switch casings are grounded.