Do you guys think it's right to talk her out of making up with this guy? So far every time idea of making up with him comes across her mind, she has called me as in "what should i do?". Do you think it's a good thing that every time i talked her out of it? I basically try to make her feel better about herself and let her know she deserves better (I know, it's cheesy).
Ethically, I think you should make every effort to point out the problems in that relationship and do your best to talk her out of ever seeing him again.
On a practical basis, don't be surprised if she disregards your advice. I hope that doesn't happen, but don't be surprised. There is a personality type that gets into these situations and tends to perpetuate and continue them. I don't know her, but there's more than a small chance that she is enabling this. My previous post was based on the assumption that she had that personality type.
Chances are that unless the police get involved and legal action is taken against him, this situation will continue.
unfortunely this sounds like a lesson in futilety