This incredible myth possibly stems from the idea of the cable capacitance that exists between the shield and conductor. In some drug and smoke-filled room an ideal was hatched that shielding in a cavity is somewhat the same as in a cable and can suck your tone. Of course - in theory it is - but the capacitor is so infinitesimally small it can't affect anything short of radar.
OP - If you want to shield - do it when you are building it. Use the Stew-Mac copper foil with the conductive adhesive. Make sure ALL grounds go only to one place - such as a screw terminal in the cavity or to the output jack.
That being said, I have a P Bass that is wired with shielded cable instead of copper foil shield - between the pots and to the output jack. And it is DEAD DEAD DEAD silent even here next to my RF and hum spewing computer. The shield of each bit of cable is soldered to the pot case. It works.
OP - If you want to shield - do it when you are building it. Use the Stew-Mac copper foil with the conductive adhesive. Make sure ALL grounds go only to one place - such as a screw terminal in the cavity or to the output jack.
That being said, I have a P Bass that is wired with shielded cable instead of copper foil shield - between the pots and to the output jack. And it is DEAD DEAD DEAD silent even here next to my RF and hum spewing computer. The shield of each bit of cable is soldered to the pot case. It works.