+1 to all of the above, don''t get me wrong. It is obvious that a musician should find and monitor his/her own methodology (a description well chosen!) for practice. I would like to add, however, the necessity to not only practice songs until you can play them dreaming, but also develop more general abilities, that will help you to deal with new material, like standard technical excersises, scales, sight reading etc.
