Sorry for the long post ahead!
There is a skill to teaching that I'd say the majority of musicians teaching haven't thought about. As Ed pointed out, people tend to teach how they were taught. There are people teaching music just because they play their instrument well, even more are teaching who can't even do that. As a result, a lot of misinformation gets spread. However, in the hands of a good teacher that lineages is magic. You have to know concepts inside out then explain them countless ways. What works for a student sat in front of you might not for the next one. Your preferences and how you learned doesn't translate into how someone else might, be flexible in your approach to that.
Personally I see teaching as of passing on information and turning that into someones knowledge. How major scales are constructed is information. You can tell that to someone and they might get it. All you've done in relay information. For a lot of teachers, the job is done. Information does not equal knowledge though, they are two different things. Exemplifying information helps it become knowledge. I'm flexible in my approach to relaying the information less flexible in what skill and knowledge I teach. Feedback and discussions with people allow me to evolve the method, but the same knowledge is being developed with everyone who studies with me.
Your methods are yours and yours alone. Me telling you what I do and how I do it won't help you develop your thing. The following questions are always worth constantly thinking about and you'll develop a method that is yours which puts the learner first.
What I would normally would do with my beginner students is shortly explain the concept I'm teaching, give a short demo and invite the student to do it
Am I operating as an authority am I a partner in learning? Am I acting as an authority or a facilitator? Is this approach directly involving the learner? How can I get the them more involved in the process? Would they benefit from problem solving? What approach would lead to more learning with an understanding rather than just the memorisation of information? Is this encouraging the learner to explore? Can I get the learner to demonstrate their understanding of the concept intellectually, physically and aurally?
a lot of basic mistakes still happen and I try to be aware of those and correct them
Is it beneficial for me to be the first to point out the mistakes and correct them? Would a learner benefit from self-assessment first and allow them the opportunity to identify mistakes and come to understanding of why they were made? Am I encouraging self direction and self reflection? Am I honest about my mistakes and encouraging life long learning? Would they benefit from repetition in order to distinguish the difference between a slip up and a gap in their knowledge? When is the right time to step in and to what extent are you impacting the learning process by doing this? Is this a good opportunity to give them something new to think about and explore?
The atmosphere is relaxed and I'm positively reinforcing stuff that's good also not being negative about what's not.
Am I engaged with the learner? Do I have any stories that are relevant to what is being taught? When is the right time to take the foot off the gas and give the learning some breathing space and time to relax? Do I have anything humorous or relatable that promotes a working relationship between us? Are these criticisms merited and how can I ensure they are constructive? Am I being honest with this person?
I'm also open for questions and music that students want to learn
What does this person want to learn and how does it fit into my curriculum? Are we able to brainstorm together to formulate an approach? Is my content relevant? Do they feel ready to move on with this? Am I encouraging discussion with the learner? Does the learner have expectations from me and do they know the expectations I have of them? If I set this person work would they benefit from me doing the same thing and then the two of us having a discussion at how we arrived at our respective conclusions and differences?
The singular question I always ask myself is: How can I make my lessons better?
This is all stuff I think about. It's why I always encourage lessons with a good teacher and not video sites as a primary source. Those resources don't tell you when someone doesn't understand, and is unable to test the knowledge. The biggest issue musicians have when it comes to teaching is the lack of focus on teaching. Ask anybody who interviews musicians for a teaching job and the single issue that stops most people getting jobs is that they talk too much about what they do and not about teaching.