I think for me that would be the TC Electronics Chorus+. This model remained on my board for about 12 years before I replaced it with an Anolog Man. The second longest would barely hit the 3 year mark so hardly worth mentioning (yet).
BTW - tuners don't count.
BTW - tuners don't count.