The preamp module should already have a reverse polarity protection inside. I mean it says Spector on it.
I didn't mean any disrespect to Stuart and his products. I just have never noticed much in the way of polarity protection on the un-potted preamps I've come across over the years. Who would change their battery with their bass still plugged in? And if you put the battery up to the clip the wrong way it's only for a moment, right? In a pedal, it's probably the same story, but the diode is to give the circuit a fighting chance if some one puts an ac voltage on the dc plug. For a few cents, I think it's not a bad idea.
IME you will lose a lot of top end and it will sound quiet and muddy if you install a pot after the TP
Sorry, I should have clarified that. You should go with a 10K or 25K pot for a post pre volume. A 250K or 500K here will cause those probslems.
What does switching the input & output of the pot accomplish?
It alters the taper and sometimes causes a more noticeable loss of treble when rolling down. Usually, the only time you see the wiper terminal wired as an input is when you don't get a choice, because there are multiple volume pots, and rolling one down would mute everything. That is not the case here, so there is no reason to accept the compromise.
All true, and also, it will increase the input Z to it's max. Which is a good thing, especially if your bass is passive. Remember, when this is installed in a bass, theres only one pot between the coils and the input of the pre. With a passive bass, there'll now be 2 to 4 pots plus a guitar cable.
In audio electronics, you have to know your load. Having a pot before a Hi Z is normally a good thing to minimise the tonal change through the sweep of the pot, but in a bass, the load a (250K) pot has on the coils has more of an effect than the load a cable and amp has on a (post pre, 25K) volume pot. In the real world, a bass vol is rarely run below 80% and will almost never see an Z of less than 50K, plus most onboard pres are made with opamps, many of which will happily drive a 1K or less Z. So having it (unbuffered) on the output is perfectly fine.
Having said this, many basses have the vol on the input of the pre for two reasons. Firstly, if it has an active/passive switch, you need a 250-500k pot for the passive setting to sound OK, and if this is on the output of a pre, it will sound bad (in the active setting). The other reason is that most pickups are voiced to sound best when directly driving a pot or two. I know this is a big generalisation, and I don't want to spark a big OT discussion about pickup winding, but IME, most pickups can sound a bit sterile if directly driving a 1Meg+ Z. Of course if you've got two pickups, you blend pot will usually load the coils up just nicely.