I'm gonna go against the grain here:
If you get a newer-production Affinity, you're a lot more likely to get a really solid, affordable instrument. The CV's and VM's have always been excellent, and honestly in a lot of cases I've felt that the fit, finish, and factory setup on a lot of Squier CVs and VMs and yes, even Affinities, has been on par with or better than the regular Fender Standards/Players. A off the rack new-production Affinity was assembled and set up well enough to
impress one of Fender's Master Builders , so that's gotta count for something. Granted, it was a Strat, but still -- same factories, same product line.
Chinese-made Squiers may have been crap 20-30 years ago, but anything made in China in the last 10 years or so is going to be really decent assuming it was decently QC'd at the factory. Probably the best run of CV basses were the 2010-2018 Chinese-made run. The thing with any factory production instrument -- and it's certainly not just overseas-made Squiers, you run into the same basic problem no matter who's made it -- is that lemons can and do and will and always will sneak through QC. Squiers get a bad rap but if you look at literally any other production company that makes instruments on an assembly line in a factory, QC mishaps happen. People have bad days, the new guy is still in training, stuff just gets missed. It happens.
For the most part the pickups aren't really anything to write home about, but they're also perfectly serviceable. If anything, newer-production Affinities make great modding platforms, but also try out the bass for yourself first and make sure you're okay with how it sounds stock before you decide you need to throw a new set of pickups in there. The truth is, for instruments made in the last 10 years or so, stock OEM pickups have really, really
really improved.
I used to be really intense about modding my instruments, but of my collection of guitars (4) and basses (3), I've tried to mod exactly one of them. It's an ESP LTD EC-256. I put a Seymour Duncan JB Humbucker in the bridge. And honestly, I took it out and sent it back because the stock OEM pickup sounded better.
There's definitely a point of diminishing returns past around $400-800 depending on the instrument and the manufacturer...and Headstock Pride/Inspiration is definitely a real thing, albeit a super weird psychological thing. You get what you pay for to a point, and then after that you're mostly paying for prestige.
Basically, you're not going to go wrong with a Squier -- and yes, that includes the Affinity series. Try to play one in a store first to get an idea with how they feel. If you don't love how it sounds you can always mod it later, or save up for something nicer.