"worst shielding ever" might be what i see in lots of new mid-price instruments, where they paint the cavities with what is in fact shielding paint, but then
don't bother to ground it
they've basically installed "antenna paint" at that point, it could
add noise
as for shielding control cavities vs pickup cavities, there's an argument for avoiding shielding that's "too good" (i.e., too
conductive, like copper foil) right near the pickups themselves; if that shielding is within the magnetic field of the pickups then it can induce eddy currents in the shielding, and said eddy currents can dull the sound of the pickups a little
so yeah, shield the control cavity definitely, shield the pickup cavities with something no more conductive than the graphite paint